1

我正在尝试通过 soundcloud API 下载曲目，然后在下载不确定数量的曲目后启动回调。当我运行下面的代码时，我看到“全部完成”被控制台记录在其他任何事情之前，即使我打算让它成为最后一件事......我做错了什么？

// Deps
import fs from 'fs'
import SC from 'node-soundcloud'
import request from 'request'

// Write mp3 function
function writeMP3(track) {
  return new Promise((resolve, reject) => {

    console.log('Starting download: ', track.title)

    request.get(track.download_url)
    .on('error', err => {
      // reject('Download error: ', err)
    })
    .on('finish', () => {
      () => resolve('Download complete')
    })
    .pipe(fs.createWriteStream(`./data/temp/${track.title}_${track.user.username}.mp3`))

  })
}

async function asyncTrackFetch(track) {
  return await writeMP3(track)
}

// Array of promises to callback upon
const trackActions = []

SC.init({
  id: 'MY_ID',
  secret: 'MY_SECRET'
})

SC.get('/tracks', (err, tracks) => {

  if (err) {
    throw new Error(err)
  } else {

    console.log('Tracks fetched: ', tracks.length)

    tracks.map(track => {

      if (track.downloadable) {
        console.log('downloadable')

        trackActions.push(asyncTrackFetch(track))

      }

    })
  }
})

// Perform requests async
Promise.all(trackActions).then(() => {
  console.log('All done')
  console.log(fs.readdirSync('./data/temp'))
})
4

2 回答 2

1

Promise.all(trackActions)等待中的任何承诺trackActions，但trackActions在您拨打电话时为空。您只是在SC.get调用回调后向数组添加承诺。

尝试将您的Promise.all...块放入SC.get回调中，如下所示：

SC.get('/tracks', (err, tracks) => {

  if (err) {
    throw new Error(err)
  } else {

    console.log('Tracks fetched: ', tracks.length)

    tracks.map(track => {

      if (track.downloadable) {
        console.log('downloadable')

        trackActions.push(asyncTrackFetch(track))

      }

    })

    Promise.all(trackActions).then(() => {
      console.log('All done')
      console.log(fs.readdirSync('./data/temp'))
    })
  }
})

值得一提的是，您的线路throw new Error(err)将使程序崩溃，因为无法捕获该错误。

正如 Antonio Val 提到的，有更好的方法来做到这一点。如果您承诺 node-soundcloud 库，那么代码的最后一部分可能如下所示：

SC.get('/tracks').then(tracks => {
  // No need for trackedActions array.
  return Promise.all(tracks.filter(track => track.downloadable)
    .map(track => asyncTrackFetch(track)))
}).then(fetchedTracks => {
  console.log('All done fetching tracks', fetchedTracks)
}).catch(err => {
  // Handle error.
})

或者在异步函数内部，

try {
  const tracks = await SC.get('/tracks')
  const fetchPromises = tracks
    .filter(track => track.downloadable)
    .map(track => asyncTrackFetch(track))
  const fetchedTracks = await Promise.all(fetchPromises)

  console('All done fetching tracks.', fetchedTracks)
} catch (err) {
  // Handle error
}
于 2017-03-12T16:26:58.620 回答
0

我认为最简单的方法是Promise.all在tracks.map循环完成后移动。

一个更优雅的解决方案是promisifySC.get并async await在你的所有代码中使用。

更新：

无法测试它，所以不确定它是否有效，但它会是这样的：

import fs from 'fs'
import SC from 'node-soundcloud'
import request from 'request'

function writeMP3(track) {
  return new Promise((resolve, reject) => {

    console.log('Starting download: ', track.title)

    request.get(track.download_url)
    .on('error', err => {
      // reject('Download error: ', err)
    })
    .on('finish', () => {
      () => resolve('Download complete')
    })
    .pipe(fs.createWriteStream(`./data/temp/${track.title}_${track.user.username}.mp3`))

  })
}

function getTracks() {
  return new Promise((resolve, reject) => {

    SC.get('/tracks', (err, tracks) => {
      if (err) {
        return reject(err)
      }

      console.log('Tracks fetched: ', tracks.length)
      resolve(tracks)
    })
  })
}

SC.init({
  id: 'MY_ID',
  secret: 'MY_SECRET'
})

与async await：

async function start() {
  const tracks = await getTracks();

  for (let track of tracks) {
    await writeMP3(track)
  }
}

start()
.then(() => {
  console.log('All done')
  console.log(fs.readdirSync('./data/temp'))
})
.catch((err) => {
  // insert error handler here
})

如果你只想使用 Promises：

getTracks
.then((tracks) => {
  const promiseArray = tracks.map((track) => {
    return writeMP3(track)
  })
  return Promise.all(promiseArray)
})
.then(() => {
  console.log('All done')
  console.log(fs.readdirSync('./data/temp'))
})
.catch((err) => {
  // insert error handler here
})
于 2017-03-12T16:26:56.173 回答