-2 
 public class leftrec {

 static int isleft(String[] left,String[] right)

    {
       int f=0;
       for(int i=0;i<left.length;i++)
       {
           for(int j=0;j<right.length;j++)

           {
               if(left[i].charAt(0)==right[j].charAt(0))
               {
                   System.out.println("Grammar is left recursive");
                   f=1;
               }

           }
       }
          return f;   
    }
    public static void main(String[] args) {
        // TODO code application logic here
        String[] left=new String[10];
        String[] right=new String[10];
        Scanner sc=new Scanner(System.in);
        System.out.println("enter no of prod");
        int n=sc.nextInt();
        for(int i=0;i<n;i++)
        {
            System.out.println("enter left prod");
            left[i]=sc.next();
            System.out.println("enter right prod");
            right[i]=sc.next();
        }

        System.out.println("the productions are");
        for(int i=0;i<n;i++)
        {
            System.out.println(left[i]+"->"+right[i]);
        }
        int flag=0;
       flag=isleft(left,right);
           if(flag==1)
           {
               System.out.println("Removing left recursion");
           }
           else
           {
               System.out.println("No left recursion");
           }       
    }
}

我编写了这段代码来确定给定的语法是否是递归的。当我编译程序时，它给我NullPointerException一行

if(left[i].charAt(0)==right[j].charAt(0))

和

isleft(left,right);

我如何删除异常？

4

3 回答 3

2

我猜您的输入有问题，您只是将字符串数组长度设为 10。

String[] left=new String[10];
String[] right=new String[10];

不要硬编码字符串数组的长度

int n=sc.nextInt();
String[] left=new String[n];
String[] right=new String[n];
for(int i=0;i<n;i++){
    System.out.println("enter left prod");
    left[i]=sc.next();
    System.out.println("enter right prod");
    right[i]=sc.next();
}

可能，这将是问题

于 2014-01-17T05:08:49.100 回答
0

您需要按如下方式更改代码：

package com.cgi.ie2.common;

import java.util.Scanner;

public class LeftRecursive {

static int isleft(String[] left, String[] right)
{
    int f = 0;
    for (int i = 0; i < left.length; i++) {
        for (int j = 0; j < right.length; j++)
        {
            if (left[i].charAt(0) == right[j].charAt(0)) {
                System.out.println("Grammar is left recursive");
                f = 1;
            }
        }
    }
    return f;
}

public static void main(String[] args) {
    // TODO code application logic here
    Scanner sc = new Scanner(System.in);
    System.out.println("enter no of prod");
    int n = sc.nextInt();
    //Changes done here::::
    String[] left = new String[n];
    String[] right = new String[n];
    for (int i = 0; i < n; i++) {
        System.out.println("enter left prod");
        left[i] = sc.next();
        System.out.println("enter right prod");
        right[i] = sc.next();
    }

    System.out.println("the productions are");
    for (int i = 0; i < n; i++) {
        System.out.println(left[i] + "->" + right[i]);
    }
    int flag = 0;
    flag = isleft(left, right);
    if (flag == 1) {
        System.out.println("Removing left recursion");
    } else {
        System.out.println("No left recursion");
    }
}
  }

此代码将消除 NullpointerExceptions

如果你没有。来自控制台的产品，字符串数组需要相应地设置，因为我所做的更改是::

    System.out.println("enter no of prod");
    int n = sc.nextInt();
    //Changes done here::::
    String[] left = new String[n];
    String[] right = new String[n];

对于更好的代码，我可以建议你的是你需要遵循基本的编码约定，这使得你的代码可读，代码不是完美的，只有当它正确运行时，如果遵循编码约定，代码是完美的，所以请通过以下链接到不了解编码约定的基本思想::

http://www.javacodegeeks.com/2012/10/java-coding-conventions-considered-harmful.html http://java.about.com/od/javasyntax/a/nameconventions.htm

于 2014-01-17T05:12:10.827 回答
0

你不能初始化一个没有大小的数组。您已经将数组大小指定为 10，如果您输入大于 10 或小于 10 的产品，则会出现错误。因此，如果你想使用动态大小，你应该使用 java 集合。最好的方法是数组列表

static int isLeft(ArrayList left, ArrayList right)

    {
        int f = 0;
        for (int i = 0; i < left.size(); i++) {
            for (int j = 0; j < right.size(); j++)

            {
                if (left.get(i).charAt(0) == right.get(j).charAt(0)) {
                    System.out.println("Grammar is left recursive");
                    f = 1;
                }

            }
        }
        return f;

    }

    public static void main(String[] args) {
        // TODO code application logic here
        ArrayList<String> left = new ArrayList<String>();
        ArrayList<String> right = new ArrayList<String>();


        Scanner sc = new Scanner(System.in);
        System.out.println("enter no of prod");
        int n = sc.nextInt();
        for (int i = 0; i < n; i++) {
            System.out.println("enter left prod");
            String leftText = sc.next();
            left.add(leftText);
            System.out.println("enter right prod");
            String rightText = sc.next();
            right.add(rightText);
        }

        System.out.println("the productions are");
        for (int i = 0; i < n; i++) {
            System.out.println(left.get(i) + "->" + right.get(i));
        }
        int flag;
        flag = isLeft(left, right);
        if (flag == 1) {
            System.out.println("Removing left recursion");
        } else {
            System.out.println("No left recursion");
        }

    }
于 2014-01-17T05:42:49.710 回答